Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c

Eric Sesterhenn / Snakebyte wrote:

* Richard Knutsson ([email protected]) wrote:

Would it not be preferable to use a 's32' instead of an 'int'? After all, it seem 'val' needs to be 32 bits.

not sure, but wouldnt this collide with platforms where an int is 64
Bits?

Because of 'phy_read'? It shouldn't as long the returning value is within the range of the s32.

Eric

Richard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] Signedness issue in drivers/net/phy/phy_device.c
    • From: Eric Sesterhenn <[email protected]>
  • Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c
    • From: Richard Knutsson <[email protected]>
  • Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c
    • From: Eric Sesterhenn / Snakebyte <[email protected]>

• Prev by Date: [PATCH 2.4.34-pre1] gcc4 fix for UP sparc64
• Next by Date: Re: [PATCH] introduce kernel_execve function to replace __KERNEL_SYSCALLS__
• Previous by thread: Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c
• Next by thread: [Patch] Signedness issue in drivers/net/3c515.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]