Question about handling return value of device_create_file function

Hi,

I have noticed that sparse generates a lot of "ignoring return value
of 'device_create_file'" warnings.

(cat sparse.txt | grep -c "device_create_file"
1231 :)

I want to fix this warnings, but I'm wondering how to properly handle
return value of device_create_file function.

The shortest way.

int foo()
{
	int error;

	[..]

	error = device_create_file(&bar, &bas)

	if (error)
		return error;
}

A bit longer way.

int foo()
{
	int error;

	[..]

	error = device_create_file(&bar, &bas)

	if (error) {
		subsystem_remove_device(bar);
		return error;
	}
}

Any hints?

Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Question about handling return value of device_create_file function
    • From: "Dmitry Torokhov" <[email protected]>

• Prev by Date: Re: [PATCH] Image capturing driver for Basler eXcite smart camera
• Next by Date: Re: [2.6.19 PATCH 3/7] ehea: queue management
• Previous by thread: "irq 17: nobody cared" killed my machine (libata, usb, 8139too)
• Next by thread: Re: Question about handling return value of device_create_file function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]