Re: cdev documentation (was Drop second arg of unregister_chrdev())

On 8/18/06, Rolf Eike Beer <[email protected]> wrote:

While I was sneaking around in the code I found this drivers/char/tty_io:3093

       cdev_init(&driver->cdev, &tty_fops);
       driver->cdev.owner = driver->owner;
       error = cdev_add(&driver->cdev, dev, driver->num);
       if (error) {
               cdev_del(&driver->cdev);

Isn't the call to cdev_del() just wrong here?

Yes, itlooks like it shouldjust be removed.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [TTY] Remove bogus call to cdev_del()
    • From: Rolf Eike Beer <[email protected]>

• References:
  • cdev documentation (was Drop second arg of unregister_chrdev())
    • From: [email protected] (Jonathan Corbet)
  • Re: cdev documentation (was Drop second arg of unregister_chrdev())
    • From: Rolf Eike Beer <[email protected]>

• Prev by Date: Re: [PATCH 2.6.18-rc4 00/10] Kernel memory leak detector 0.9
• Next by Date: Re: [ckrm-tech] [RFC][PATCH 2/7] UBC: core (structures, API)
• Previous by thread: Re: cdev documentation (was Drop second arg of unregister_chrdev())
• Next by thread: [TTY] Remove bogus call to cdev_del()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]