Re: [PATCH 5/6] IP100A correct init and close step

Jesse Huang wrote:

Hi Jeff:
(1)Should I change to :
spin_lock_irqsave(&np->lock,flags);
reset_tx(dev);
spin_lock_irqrestore(&np->lock,flags);

(2)I will remove date and author information out of source code comment.

Correct.

Also:

(3) Use iowrite16(), not writew(). I just noticed this bug. iowrite16() will work for both MMIO and IO cycles, writew() only works for MMIO.

(4) We need a description of why this change is needed. What does writing 0x500 to DMACtrl actually do? Why do we need to do this?

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/6] IP100A correct init and close step
    • From: "Jesse Huang" <[email protected]>

• References:
  • [PATCH 5/6] IP100A correct init and close step
    • From: Jesse Huang <[email protected]>
  • Re: [PATCH 5/6] IP100A correct init and close step
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 5/6] IP100A correct init and close step
    • From: "Jesse Huang" <[email protected]>

• Prev by Date: Re: [RFC][PATCH 2/7] UBC: core (structures, API)
• Next by Date: Re: [take9 2/2] kevent: poll/select() notifications. Timer notifications.
• Previous by thread: Re: [PATCH 5/6] IP100A correct init and close step
• Next by thread: Re: [PATCH 5/6] IP100A correct init and close step
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]