Re: [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address

Jesse Huang wrote:

-/* Work-around for Kendin chip bugs. */
-#ifndef CONFIG_SUNDANCE_MMIO
-#define USE_IO_OPS 1
-#endif

Why? This simply eliminates the ability of the user to set the driver configuration at Kconfig time, requiring them to edit the driver to achieve the same functionality.

@@ -491,10 +487,13 @@ #endif
 	if (pci_request_regions(pdev, DRV_NAME))
 		goto err_out_netdev;

- ioaddr = pci_iomap(pdev, bar, netdev_io_size);

+	ioaddr =(void __iomem *)

+ ((unsigned long)pci_iomap(pdev, bar, netdev_io_size) & + 0xffffff80);

NAK, this is very wrong. pci_iomap() returns a "cookie", which you are not allowed to modify in any way.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address
    • From: Jesse Huang <[email protected]>

• Prev by Date: Re: [PATCH 1/6] IP100A, add end of pci id table
• Next by Date: Re: PATCH/FIX for drivers/cdrom/cdrom.c
• Previous by thread: [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address
• Next by thread: [PATCH 4/6] IP100A Change search phy addr start form 0
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]