Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex

On 08/15, Esben Nielsen wrote:
> 
> On Tue, 15 Aug 2006, Oleg Nesterov wrote:
> >
> >Sure, this needs a comment.
> 
> It is even better if you can read the code without a comment. Good code 
> doesn't need comments.

Yes. But from my point of view, the current code needs a comment to explain
why do we take ->pi_lock, this is hard to understand at least to me.

It is even better if we don't take ->pi_lock for ->wait_list manipulation.

Imho.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Esben Nielsen <[email protected]>
  • Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Esben Nielsen <[email protected]>
  • Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
    • From: Esben Nielsen <[email protected]>

• Prev by Date: Re: [PATCH][Fix] swsusp: Fix swap_type_of
• Next by Date: Re: [PATCH 4/6] ehea: header files
• Previous by thread: Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex
• Next by thread: [PATCH] ifdef blktrace debugging fields
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]