Re: [PATCH for review] [130/145] i386: clean up topology.c

On Thu, 2006-08-10 at 21:37 +0200, Andi Kleen wrote:
>  static int __init topology_init(void)
>  {
>         int i;
>  
> +#ifdef CONFIG_NUMA
>         for_each_online_node(i)
>                 register_one_node(i);
> +#endif /* CONFIG_NUMA */
>  
>         for_each_present_cpu(i)
>                 arch_register_cpu(i);
>         return 0;
>  } 

Wouldn't it be more proper here to make register_one_node() have a
non-NUMA definition, instead of putting an #ifdef in a .c file like
this?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH for review] [130/145] i386: clean up topology.c
    • From: "Magnus Damm" <[email protected]>
  • Re: [PATCH for review] [130/145] i386: clean up topology.c
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH for review] [130/145] i386: clean up topology.c
    • From: Andi Kleen <[email protected]>

• Prev by Date: [PATCH for review] [103/145] i386/x86-64: rename is_at_popf(), add iret to tests and fix
• Next by Date: Re: [PATCH for review] [3/145] i386: Allow to use GENERICARCH for UP kernels
• Previous by thread: [PATCH for review] [130/145] i386: clean up topology.c
• Next by thread: Re: [PATCH for review] [130/145] i386: clean up topology.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]