On Tue 08-08-06 15:22:34, Muli Ben-Yehuda wrote:
> On Mon, Aug 07, 2006 at 08:20:47PM +0200, Björn Steinbrink wrote:
> > On 2006.08.07 19:30:55 +0300, Shem Multinymous wrote:
> > > Hi Pavel,
> > >
> > > On 8/7/06, Pavel Machek <[email protected]> wrote:
> > > >> + int total, ret;
> > > >> + for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {
> > > >
> > > >Could we go from 0 to timeout, not the other way around?
> > >
> > > Sure.
> > > (That's actually vanilla hdapsd code, moved around...)
> >
> > Maybe you could convert that to sth. like this along the way?
> >
> > int ret;
> > unsigned long timeout = jiffies + msec_to_jiffies(READ_TIMEOUT_MSECS);
> > for (;;) {
> > ret = thinkpad_ec_lock();
> > if (ret)
> > return ret;
>
> Just in case someone was going to cut and paste, this will return with
> the ec_lock taken.
Well, taking lock failed (hence error return) so I think code is
correct.
--
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
