Re: [Lhms-devel] [PATCH 4/10] hot-add-mem x86_64: Enable SPARSEMEM in srat.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Keith Mannthey wrote:
From: Keith Mannthey <[email protected]>

 Enable x86_64 srat.c to share code between both reserve and sparsemem based add memory
paths. Both paths need the hot-add area node locality infomration (nodes_add). This code refactors the code path to allow this.
Signed-off-by: Keith Mannthey<[email protected]>
Ok nice, but.... hotadd_enough_memory() is broken, it does weird things with nd->start and nd->end which haven't been assigned even values yet. Also, mysterious business with find_e820_area and last_area_end...These areas are not in e820...
And why the reserve_bootmem_node()? Areas not RAM (per e820) are 
reserved anyways.
--Mika

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux