Re: [PATCH] lockdep: don't pull in includes when lockdep disabled

On Wed, Jul 26, 2006 at 08:33:19AM +0200, Arjan van de Ven wrote:
> On Wed, 2006-07-26 at 09:26 +0300, Michael S. Tsirkin wrote:
> > Ingo, does the following look good to you?
> >
> > Do not pull in various includes through lockdep.h if lockdep is disabled.
> 
> Hi,
> 
> can you tell us what this fixes? Eg is there a specific problem?

[raises hand]
Zillions of warnings on m68k allmodconfig. And, yes, patch removes them.

In file included from ...
		 from ...
include/linux/list.h: In function `__list_add_rcu':
include/linux/list.h:89: warning: implicit declaration of function `smp_wmb'

> I mean... we're adding ifdefs so there better be a real good reason for
> them.... fixing something real would be such a reason ;-)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- Re: [PATCH] mthca: initialize send and receive queue locks separately
  - From: Ingo Molnar <[email protected]>
- [PATCH] lockdep: don't pull in includes when lockdep disabled
  - From: "Michael S. Tsirkin" <[email protected]>
- Re: [PATCH] lockdep: don't pull in includes when lockdep disabled
  - From: Arjan van de Ven <[email protected]>

Prev by Date: Re: [PATCH] update I/O sched Kconfig help texts - CFQ is now default, not AS.
Next by Date: Re: [stable] Success: tty_io flush_to_ldisc() error message triggered
Previous by thread: Re: [PATCH] lockdep: don't pull in includes when lockdep disabled
Next by thread: Re: [openib-general] [PATCH] mthca: initialize send and receive queue locks separately
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]