Citerar Jan Engelhardt <[email protected]>:
>
> >Hopefully it is now ready for a "real" patch, whom adds bool to all
> >arches. If there is no comments on this one, it will be sent about
> >tomorrow night (GMT).
>
> --- a/drivers/block/DAC960.h
> +++ b/drivers/block/DAC960.h
> @@ -71,7 +71,7 @@ #define DAC690_V2_PciDmaMask 0xfffffffff
> Define a Boolean data type.
> */
>
> -typedef enum { false, true } __attribute__ ((packed)) boolean;
> +typedef bool boolean;
>
>
> /*
>
> Looks good. (I know found out what this is good for. Eventually, all
> booleans
> in the source of DAC960 et al. should be changed to just 'bool' but that's
> another patch's job.)
Yepp :)
> Looks good, except for the "all arches" thing. You only seem to add it
> to i386:
I said: 'ready for a "real" patch', meaning it will be in another patch.
Will try to be more clear in the future.
> >+#undef false
> >+#undef true
> >+
> >+enum {
> >+ false = 0,
> >+ true = 1
> >+};
> >+
> >+#define false false
> >+#define true true
>
> Can someone please tell me what advantage 'define true true' is going to
> bring, besides than being able to '#ifdef true'?
Assembly-code can not use enum but #define. That is the reason I find but there
might be more.
> Jan Engelhardt
/Richard Knutsson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
