Using the patch below that you sent me, this message printed today on
my SMP system when terminating pppd:
flush_to_ldisc - TTY_FLUSHING set, low_latency=0
And this bug is also in 2.6.17.4 - I forgot to reboot into 2.6.16.x
and the system locked up the same way 2.6.16 used to. That was made
even more fun by the 'SysRq broken on SMP' bug fixed by a pending
2.6.17.7 patch...
--- 2.6.16.20-d4.orig/include/linux/tty.h
+++ 2.6.16.20-d4/include/linux/tty.h
@@ -266,6 +266,7 @@ struct tty_struct {
#define TTY_PTY_LOCK 16 /* pty private */
#define TTY_NO_WRITE_SPLIT 17 /* Preserve write boundaries to driver */
#define TTY_HUPPED 18 /* Post driver->hangup() */
+#define TTY_FLUSHING 19 /* Flushing tty buffers to line discipline */
#define TTY_WRITE_FLUSH(tty) tty_write_flush((tty))
--- 2.6.16.20-d4.orig/drivers/char/tty_io.c
+++ 2.6.16.20-d4/drivers/char/tty_io.c
@@ -2781,9 +2781,12 @@ static void flush_to_ldisc(void *private
return;
if (test_bit(TTY_DONT_FLIP, &tty->flags)) {
- /*
- * Do it after the next timer tick:
- */
+ printk(KERN_ERR"flush_to_ldisc - TTY_DONT_FLIP set\n");
+ schedule_delayed_work(&tty->buf.work, 1);
+ goto out;
+ }
+ if (test_and_set_bit(TTY_FLUSHING, &tty->flags)) {
+ printk(KERN_ERR"flush_to_ldisc - TTY_FLUSHING set, low_latency=%d\n", tty->low_latency);
schedule_delayed_work(&tty->buf.work, 1);
goto out;
}
@@ -2805,6 +2808,7 @@ static void flush_to_ldisc(void *private
tty_buffer_free(tty, tbuf);
}
spin_unlock_irqrestore(&tty->buf.lock, flags);
+ clear_bit(TTY_FLUSHING, &tty->flags);
out:
tty_ldisc_deref(disc);
}
--
Chuck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
