Re: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()

On 10/07/06, Christoph Hellwig <[email protected]> wrote:

> -static inline void uid_hash_insert(struct user_struct *up, struct list_head *hashent)
> +static inline void uid_hash_insert(struct user_struct *_up, struct list_head *hashent)
>  {

Please never use such ugly names.  A simply 'u' as variable name would do it
instead in most places.

Ok, will do.
Thank you for the feedback.

--
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()
    • From: Jesper Juhl <[email protected]>
  • Re: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()
• Next by Date: Re: [-mm patch] kernel/rcutorture.c: make code static
• Previous by thread: Re: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()
• Next by thread: [RFC][PATCH 8/9] -Wshadow: vgacon fixes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]