On Thu, Jun 29, 2006 at 12:44:00PM -0700, Andrew Morton wrote:
> On Thu, 29 Jun 2006 12:36:08 -0700
> Andrew Morton <[email protected]> wrote:
>
> > On Thu, 29 Jun 2006 21:19:40 +0200
> > Adrian Bunk <[email protected]> wrote:
> >
> > > This patch removes the following unused exports:
> > > - EXPORT_SYMBOL:
> > > - in_egroup_p
> > > - EXPORT_SYMBOL_GPL's:
> > > - kernel_restart
> > > - kernel_halt
> >
> > Switch 'em to EXPORT_UNUSED_SYMBOL and I'll stop dropping your patches ;)
> >
>
> If doing this, I'd suggest it be done thusly:
>
> EXPORT_UNUSED_SYMBOL(in_egroup_p); /* June 2006 */
>
> to aid later decision-making.
I had some bad experiences with following processes you suggest the
doesn't remove the symbol immediately:
As you wanted me to do, I scheduled the EXPORT_SYMBOL(insert_resource)
for removal on 2 May 2005 with both __deprecated_for_modules and an
entry in feature-removal-schedule.txt with the target date April 2006.
On 11 Apr 2006, I sent the patch to implement this scheduled removal.
As of today, the latter patch is still stuck in -mm (which isn't better
than having it dropped) although it's long overdue.
Do you understand why I distrust your "to aid later decision-making"?
Can you state publically "If there's still no in-kernel user after six
months, the removal is automatically ACK'ed."?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
