On Thu, 29 Jun 2006 13:03:23 -0500
Andy Fleming wrote:
[snip]
> >>> + iounmap(bcsr_regs);
> >>> +
> >> And if we have a design, which do not contain real ethernet UCC
> >> usage? Or UCC
> >> geth is disabled somehow explicitly? Stuff like that normally
> >> goes to the
> >> callback that is going to be triggered upon Etherbet init.
> > I will move it.
>
>
> Wait...no. I don't understand Vitaly's objection. If someone
> creates a board with an 8360 that doesn't use the UCC ethernet, they
> can create a separate board file. This is the board-specific code,
> and it is perfectly acceptable for it to reset the PHY like this.
> What ethernet callback could be used?
>
I am sort of against the unconditional trigger of the ethernet-specific stuff,
dependless if UCC eth is really wanted in specific configuration.
For stuff like that I'd make a function (to setup low-level stuff), and pass it
via platform_info to the eth driver, so that really driver-specific things happen in driver context only.
Yes this is board specific file, and virtually everything needed for the board can take place here.
But usually BCSR acts as a toggle for a several things, and IOW, I see it more correct to trigger those stuff from the respective drivers (using a callback passed through platform_info)
-Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
