Re: [PATCH 4/7] powerpc: Add QE library qe_lib--ucc support

> +int ucc_set_qe_mux_mii_mng(int ucc_num)
> +{
> +	unsigned long flags;
> +
> +	local_irq_save(flags);
> +	out_be32(&qe_immr->qmx.cmxgcr,
> +		 ((in_be32(&qe_immr->qmx.cmxgcr) &
> +		   ~QE_CMXGCR_MII_ENET_MNG) |
> +		  (ucc_num << QE_CMXGCR_MII_ENET_MNG_SHIFT)));
> +	local_irq_restore(flags);

Using local_irq_save to protect hardware access is wrong.  Please use
spinlocks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 4/7] powerpc: Add QE library qe_lib--ucc support
    • From: Li Yang-r58472 <[email protected]>

• Prev by Date: Re: [PATCH 3/7] powerpc: Add QE library qe_lib--common files
• Next by Date: Re: [-mm patch] kernel/rcutorture.c: make code static
• Previous by thread: [PATCH 4/7] powerpc: Add QE library qe_lib--ucc support
• Next by thread: [PATCH] fix kbuild module names (was: Re: oom-killer problem)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]