Re: [PATCH 4/4] Slab Reclaim logic

On Thu, 22 Jun 2006, Christoph Lameter wrote:
> > s/nr_freed/ret/
> 
> ret is non descriptive. nr_freed is describing what the purpose of the 
> variable is.
> 
> > > +	while (nr_freed < slabs_to_free) {
> > > +		int x;
> > 
> > s/x/nr_freed/
> 
> Would shadow variable.

Which is why I suggested using ret for the return variable.  Not a biggie, 
though, obviously.

				Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC 0/4] Object reclaim via the slab allocator V1
    • From: Christoph Lameter <[email protected]>
  • [PATCH 4/4] Slab Reclaim logic
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH 4/4] Slab Reclaim logic
    • From: Pekka J Enberg <[email protected]>
  • Re: [PATCH 4/4] Slab Reclaim logic
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [PATCH] stop on cpu lost
• Next by Date: Re: [PATCH 4/4] Slab Reclaim logic
• Previous by thread: Re: [PATCH 4/4] Slab Reclaim logic
• Next by thread: Re: [PATCH 4/4] Slab Reclaim logic
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]