[patch 1/3] Drop tasklist lock in do_sched_setscheduler

There is no need to hold tasklist_lock across the setscheduler call, when we
pin the task structure with get_task_struct(). Interrupts are disabled in 
setscheduler anyway and the permission checks do not need interrupts disabled.

Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>

 kernel/sched.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-2.6.17-mm/kernel/sched.c
===================================================================
--- linux-2.6.17-mm.orig/kernel/sched.c	2006-06-22 10:26:11.000000000 +0200
+++ linux-2.6.17-mm/kernel/sched.c	2006-06-22 10:26:11.000000000 +0200
@@ -4140,8 +4140,10 @@
 		read_unlock_irq(&tasklist_lock);
 		return -ESRCH;
 	}
-	retval = sched_setscheduler(p, policy, &lparam);
+	get_task_struct(p);
 	read_unlock_irq(&tasklist_lock);
+	retval = sched_setscheduler(p, policy, &lparam);
+	put_task_struct(p);
 	return retval;
 }
 

--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/3] Drop tasklist lock in do_sched_setscheduler
    • From: Andrew Morton <[email protected]>
  • Re: [patch 1/3] Drop tasklist lock in do_sched_setscheduler
    • From: Andrew Morton <[email protected]>

• References:
  • [patch 0/3] rtmutex: Propagate priority setting into lock chains
    • From: Thomas Gleixner <[email protected]>

• Prev by Date: [patch 0/3] rtmutex: Propagate priority setting into lock chains
• Next by Date: [patch 3/3] rtmutex: Modify rtmutex-tester to test the setscheduler propagation
• Previous by thread: Re: [patch 2/3] rtmutex: Propagate priority settings into PI lock chains
• Next by thread: Re: [patch 1/3] Drop tasklist lock in do_sched_setscheduler
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]