Re: [PATCH] ide: fix revision comparison in ide_in_drive_list

21 Jun 2006 15:44, Alan Cox wrote:
> > id->model="TRANSCEND",
> > id->fw_rev="20050811TRANSCEND"
> > 
> > note the trailing in id->fw_rev,
> 
> These are not null terminated strings in the ident block. So if you
> merely print them or test against them you'll break on 8 char long
> firmware names. They may also be space rather than \0 padded if shorter
This justifies strstr usage.

Thanks again.

-- 
	Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] ide: fix revision comparison in ide_in_drive_list
    • From: Kirill Smelkov <[email protected]>
  • Re: [PATCH] ide: fix revision comparison in ide_in_drive_list
    • From: Kirill Smelkov <[email protected]>
  • Re: [PATCH] ide: fix revision comparison in ide_in_drive_list
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: [PATCH] autofs4 needs to force fail return revalidate
• Next by Date: [PATCH 1/2] VFS: Permit filesystem to override root dentry on mount [try #2]
• Previous by thread: Re: [PATCH] ide: fix revision comparison in ide_in_drive_list
• Next by thread: [PATCH] ide: disable dma for transcend CF
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]