Re: [PATCH] use unlikely() for current_kernel_time() loop

On 08 Jun 2006 04:28:12 +0200
Andi Kleen <[email protected]> wrote:

> Andreas Dilger <[email protected]> writes:
> 
> > Hello,
> > I just noticed this minor optimization.  current_kernel_time() is called
> > from current_fs_time() so it is used fairly often but it doesn't use
> > unlikely(read_seqretry(&xtime_lock, seq)) as other users of xtime_lock do.
> > Also removes extra whitespace on the empty line above.
> 
> It would be better to put the unlikely into the read_seqretry I guess.
> 

yup.  But it'd be good to check that this actually causes the compiler to
do the right thing, rather than simply ignoring it.

I'm not sure how one would do that though.  I guess compare
before-and-after assembly code, work out if "after" is better.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] use unlikely() for current_kernel_time() loop
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] use unlikely() for current_kernel_time() loop
    • From: Andreas Dilger <[email protected]>
  • Re: [PATCH] use unlikely() for current_kernel_time() loop
    • From: Andi Kleen <[email protected]>

• Prev by Date: 2.6.17-rc6-mm1 -- BUG: possible circular locking deadlock detected!
• Next by Date: Re: 2.6.17-rc6-mm1
• Previous by thread: Re: [PATCH] use unlikely() for current_kernel_time() loop
• Next by thread: Re: [PATCH] use unlikely() for current_kernel_time() loop
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]