Re: [PATCH] fix generic HDLC synclink mismatch build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
On Wed, Jun 07, 2006 at 10:42:58AM -0500, Paul Fulghum wrote:

Fix build errors caused by generic HDLC
and synclink configuration mismatch. Generic HDLC
symbols referenced from synclink drivers do not
resolve if synclink drivers are built-in and generic
HDLC is modularized.


Please fix the code instead.  _No_ kernel code should be doing
	#define CONFIG_{xxx}

because that is a reserved namespace.

I'm happy to leave the code as is, as it has been working
for the past 8 years. I'm just trying to fix build errors
for random (unusable) kernel configs that a few people
have complained about.

Many, many people have chimed in so far without looking
at the details and I keep responding many, many, many times
that the generic HDLC support is *optional* for the synclink drivers.

So your suggestion of 'fixing' the code will *break* it.
Either unnecessary code is forced on someone, or
they are deprived of necessary code.

But OK, I'm willing to listen: how do you suggest optionally
including generic HDLC support in the synclink drivers,
depending on whether generic HDLC is enabled without
referring to a configuration option?

--
Paul

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux