Re: [PATCH] fix generic HDLC synclink mismatch build error

Hi,

On Wed, 7 Jun 2006, Paul Fulghum wrote:

> -#ifdef CONFIG_HDLC_MODULE
> +#if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
>  #define CONFIG_HDLC 1
>  #endif

Please don't define your own config symbols, just use Kconfig for this, 
simply remove the prompts from your earlier patch and add the dependecies 
as Randy suggested.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix generic HDLC synclink mismatch build error
    • From: Paul Fulghum <[email protected]>

• References:
  • [PATCH] fix generic HDLC synclink mismatch build error
    • From: Paul Fulghum <[email protected]>

• Prev by Date: Re: Automatic bug hunting
• Next by Date: Re: [PATCH] fix generic HDLC synclink mismatch build error
• Previous by thread: Re: [PATCH] fix generic HDLC synclink mismatch build error
• Next by thread: Re: [PATCH] fix generic HDLC synclink mismatch build error
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]