Re: [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts

On Mon, 2006-06-05 at 21:20 -0700, Andrew Morton wrote:
> On Mon, 05 Jun 2006 23:33:50 -0400
> Steven Rostedt <[email protected]> wrote:
> 
> > 
> > Hit the following BUG with irqpoll.  The below patch fixes it.
> > 
> 
> Call me a cynic, but
> 
> > +		if (work && disc->chip && desc->chip->end)
> 
> that doesn't look super-tested to me.

No, it hasn't been refreshed! Damn quilt!

Signed-off-by: Steven Rostedt <[email protected]>


Index: linux-2.6.17-rc5-mm3/kernel/irq/spurious.c
===================================================================
--- linux-2.6.17-rc5-mm3.orig/kernel/irq/spurious.c	2006-06-05 17:26:15.000000000 -0400
+++ linux-2.6.17-rc5-mm3/kernel/irq/spurious.c	2006-06-06 06:43:43.000000000 -0400
@@ -77,7 +77,7 @@ static int misrouted_irq(int irq, struct
 		 * If we did actual work for the real IRQ line we must let the
 		 * IRQ controller clean up too
 		 */
-		if (work)
+		if (work && desc->chip && desc->chip->end)
 			desc->chip->end(i);
 		spin_unlock(&desc->lock);
 	}



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Arjan van de Ven <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Steven Rostedt <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Alan Cox <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Steven Rostedt <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Arjan van de Ven <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Steven Rostedt <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Alan Cox <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Steven Rostedt <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Alan Cox <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Steven Rostedt <[email protected]>
  • Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq()
    • From: Ingo Molnar <[email protected]>
  • [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.5
• Next by Date: Re: [RFC 3/5] sched: Add CPU rate hard caps
• Previous by thread: Re: [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts
• Next by thread: Re: [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]