Re: [PATCH 5/6] nfs: check all iov segments for correct memory access rights

Andrew Morton wrote:

+		if (unlikely(!access_ok(type, buf, len))) {
+			retval = -EFAULT;
+			goto out;
+		}

Now what's up here?  Why does NFS, at this level, care about the page's
virtual address?  get_user_pages() will handle that?

I guess I'm not clear on what behavior is desired for scatter/gather if one of the segments in an iov fails.

If one of the iov's will cause an EFAULT, how is that reported back to the application, and what happens to the I/O being requested in the other segments of the vector? When do we use an "all or nothing" semantic, and when is it OK for some segments to fail?

--
corporate:	cel at netapp dot com
personal:	chucklever at bigfoot dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/6] nfs: check all iov segments for correct memory access rights
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH 0/6] Support scatter/gather I/O in NFS direct I/O path
    • From: Chuck Lever <[email protected]>
  • [PATCH 5/6] nfs: check all iov segments for correct memory access rights
    • From: Chuck Lever <[email protected]>
  • Re: [PATCH 5/6] nfs: check all iov segments for correct memory access rights
    • From: Andrew Morton <[email protected]>

• Prev by Date: [patch] Add a sysfs file to determine if a kexec kernel is loaded
• Next by Date: Re: [PATCH] sector_t overflow in block layer
• Previous by thread: Re: [PATCH 5/6] nfs: check all iov segments for correct memory access rights
• Next by thread: Re: [PATCH 5/6] nfs: check all iov segments for correct memory access rights
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]