Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes

• To: "Bryan O'Sullivan" <[email protected]>
• Subject: Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
• From: Roland Dreier <[email protected]>
• Date: Wed, 17 May 2006 22:17:50 -0700
• Authentication-results: sj-dkim-1.cisco.com; [email protected]; dkim=pass ( sig from cisco.com verified; );
• Cc: Dave Olson <[email protected]>, [email protected], [email protected]
• Dkim-signature: a=rsa-sha1; q=dns; l=307; t=1147929471; x=1148793471; c=relaxed/simple; s=sjdkim1001; h=From:Subject; d=cisco.com; [email protected]; z=From:Roland=20Dreier=20<[email protected]> |Subject:Re=3A=20[openib-general]=20Re=3A=20[PATCH=2035=20of=2053]=20ipath=20-=20 some=20interrelated=20stability=20and=20cleanliness=20fixes; X=v=3Dcisco.com=3B=20h=3D5UBXWXTnE1cuHmDRpNCn961Nbxs=3D; b=ovscAlmi+FyAaeBLIR2p8pcytL8h96GNIq7a+DS+ShVNCTN5dvLJdMPRiKPRUdrNmZhzA83E TE9dI/JbEfS6ZlcdSwBiS1fPY0FnfniPuzZLA6n6yPOvC9XTZLM8/yDB;
• In-reply-to: <[email protected]> (Bryan O'Sullivan's message of "Wed, 17 May 2006 22:15:11 -0700")
• References: <[email protected]> <fa.yXZlqXBzNi9Gq/[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)

    Bryan> Wow.  I have no idea where that extra "goto bail" came
    Bryan> from.  It's not supposed to be there.

Even without it you still leak the work structure, because there's no
schedule_work().

Now that I look at it, in uverbs_mem.c, the mm will be leaked if the
kmalloc fails...

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
    • From: Dave Olson <[email protected]>
  • Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
    • From: Roland Dreier <[email protected]>
  • Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
    • From: Dave Olson <[email protected]>
  • Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
    • From: Roland Dreier <[email protected]>
  • Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
    • From: "Bryan O'Sullivan" <[email protected]>

• Prev by Date: Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
• Next by Date: Re: [RFC][PATCH 1/6] kconfigurable resources core changes
• Previous by thread: Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
• Next by thread: Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]