Re: [RFC: 2.6 patch] fs/bio.c: possible cleanups

On Tue, May 16 2006, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make the follwing needlessly global function static:
>   - __bio_clone()

NAK, it's part of the API (and I just had to use it the other day with
fcache).

> - don't mark the following _global_ functions as inline:
>   - bio_phys_segments()
>   - bio_hw_segments()

Ack.

> - remove the following unused EXPORT_SYMBOL's:
>   - bio_phys_segments
>   - bio_hw_segments
>   - bio_map_kern
>   - bio_copy_user
>   - bio_uncopy_user

NAK, also part of the API. Leave them.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC: 2.6 patch] fs/bio.c: possible cleanups
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [RFC: 2.6 patch] block/ll_rw_blk.c: possible cleanups
• Next by Date: Re: [PATCH] fix mem-leak in netfilter
• Previous by thread: [RFC: 2.6 patch] fs/bio.c: possible cleanups
• Next by thread: [2.6 patch] drivers/base/firmware_class.c: cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]