Re: [PATCH] add slab_is_available() routine for boot code

On Wed, May 10, 2006 at 03:50:26PM -0700, Andrew Morton wrote:
> Mike Kravetz <[email protected]> wrote:
> > diff -Naupr linux-2.6.17-rc3-mm1/mm/sparse.c linux-2.6.17-rc3-mm1.work3/mm/sparse.c
> > --- linux-2.6.17-rc3-mm1/mm/sparse.c	2006-05-03 22:19:16.000000000 +0000
> > +++ linux-2.6.17-rc3-mm1.work3/mm/sparse.c	2006-05-10 19:15:56.000000000 +0000
> > @@ -32,7 +32,7 @@ static struct mem_section *sparse_index_
> >  	unsigned long array_size = SECTIONS_PER_ROOT *
> >  				   sizeof(struct mem_section);
> >  
> > -	if (system_state == SYSTEM_RUNNING)
> > +	if (slab_is_available())
> >  		section = kmalloc_node(array_size, GFP_KERNEL, nid);
> >  	else
> >  		section = alloc_bootmem_node(NODE_DATA(nid), array_size);
> 
> Is this a needed-for-2.6.17 fix?

I'll let Arnd answer.  He ran into this when doing some Cell work.  Not
sure where in the development cycle the code is that exposes this bug.

-- 
Mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] add slab_is_available() routine for boot code
    • From: Arnd Bergmann <[email protected]>
  • Re: [PATCH] add slab_is_available() routine for boot code
    • From: Benjamin Herrenschmidt <[email protected]>

• References:
  • [PATCH] add slab_is_available() routine for boot code
    • From: Mike Kravetz <[email protected]>
  • Re: [PATCH] add slab_is_available() routine for boot code
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH -mm] swsusp: support creating bigger images
• Next by Date: Re: [PATCH] mm: cleanup swap unused warning
• Previous by thread: Re: [PATCH] add slab_is_available() routine for boot code
• Next by thread: Re: [PATCH] add slab_is_available() routine for boot code
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]