Re: [PATCH] make kernel ignore bogus partitions

On Tue, May 09, 2006 at 12:41:38PM -0700, Andrew Morton wrote:

> > +		if (from+size-1 > get_capacity(disk)) {
> > +			printk(" %s: p%d exceeds device capacity, ignoring.\n", 
> > +				disk->disk_name, p);
> > +			continue;
> > +		}
> >  		add_partition(disk, p, from, size);

> Shouldn't that be
> 
> 	if (from+size > get_capacity(disk)) {
> 
> ?

Ha, you are awake. Yes, it should.
And no "ignoring". And no "continue". E.g.:

	printk(" %s: warning: p%d exceeds device capacity.\n", ...);

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] make kernel ignore bogus partitions
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] make kernel ignore bogus partitions
    • From: "Mike Miller (OS Dev)" <[email protected]>
  • Re: [PATCH] make kernel ignore bogus partitions
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 0/5] clocksource patches
• Next by Date: Re: [RFC PATCH 05/35] Add sync bitops
• Previous by thread: Re: [PATCH] make kernel ignore bogus partitions
• Next by thread: Re: [PATCH] make kernel ignore bogus partitions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]