Re: [patch 4/4] change slab poison pattern

Hi,

On Mon, 2006-04-24 at 16:33 +0800, Akinobu Mita wrote:
> kref debugging cannot detect kref_put() with unreferenced object,
> when the structure including kref is allocated by slab
> and slab debugging config is enabled.
> 
> Because use-after-free poisoning make kref counter signed value.
> So this patch prevents it by changing poisoning pattern.

Then why not check against POISON_INUSE when CONFIG_SLAB_DEBUG in the
kref debugging code? I would prefer you didn't change the slab constants
(they're well known by everyone now) but if you must, at least stick a
big fat comment there.

			Pekka

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 4/4] change slab poison pattern
    • From: Akinobu Mita <[email protected]>

• References:
  • [patch 0/4] kref debugging
    • From: Akinobu Mita <[email protected]>
  • [patch 4/4] change slab poison pattern
    • From: Akinobu Mita <[email protected]>

• Prev by Date: Re: [(take 2)patch 7/7] Notify page fault call chain
• Next by Date: Re: Re: [RFC][PATCH 5/9] CPU controller - Documents how the controller works
• Previous by thread: [patch 4/4] change slab poison pattern
• Next by thread: Re: [patch 4/4] change slab poison pattern
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]