Re: [patch 1/5] mm: remap_vmalloc_range

Nick Piggin <[email protected]> wrote:
>
> > 
> > - are vma->vm_start and vma->vm_end always a multiple of PAGE_SIZE?  (I
> >   always forget).  If not, remap_valloc_range() looks a tad buggy.
> 
> I hope so.

do_mmap_pgoff() seems to dtrt.  It makes one wonder why vm_start and vm_end
aren't in units of PAGE_SIZE.

> > 
> > - remap_valloc_range() would lose a whole buncha typecasts if you use the
> >   gcc pointer-arith-with-void* extension.
> 
> Should I?

Well it's a gccism, and a good one.  We have lots of gccisms and using this
one here will neaten things up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/5] mm: improve remapping of vmalloc regions
    • From: Nick Piggin <[email protected]>
  • [patch 1/5] mm: remap_vmalloc_range
    • From: Nick Piggin <[email protected]>
  • Re: [patch 1/5] mm: remap_vmalloc_range
    • From: Andrew Morton <[email protected]>
  • Re: [patch 1/5] mm: remap_vmalloc_range
    • From: Nick Piggin <[email protected]>

• Prev by Date: [PATCH] sys_vmsplice
• Next by Date: Re: [patch 1/5] mm: remap_vmalloc_range
• Previous by thread: Re: [patch 1/5] mm: remap_vmalloc_range
• Next by thread: [patch 4/5] mm: extra remap_vmalloc_range check
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]