Re: [PATCH 4/7] FS-Cache: Export find_get_pages()

David Howells <[email protected]> wrote:
>
> Christoph Hellwig <[email protected]> wrote:
> 
> > > The attached patch exports find_get_pages() for use by the kAFS filesystem
> > > in conjunction with it caching patch.
> > 
> > Why don't you use pagevec ?
> 
> You mean pagevec_lookup() I suppose... That's probably reasonable, though
> slower.
> 

But the code's using pagevecs now.  In a strange manner.

+		nr_pages = find_get_pages(vnode->vfs_inode.i_mapping, first,
+					  PAGEVEC_SIZE, pvec.pages);

that's an open-coded pagevec_lookup().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 4/7] FS-Cache: Export find_get_pages()
    • From: Christoph Hellwig <[email protected]>
  • [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit
    • From: David Howells <[email protected]>
  • [PATCH 4/7] FS-Cache: Export find_get_pages()
    • From: David Howells <[email protected]>
  • Re: [PATCH 4/7] FS-Cache: Export find_get_pages()
    • From: David Howells <[email protected]>

• Prev by Date: Re: [RFC][PATCH 0/11] security: AppArmor - Overview
• Next by Date: Re: [PATCH] Rename "swapper" to "idle"
• Previous by thread: Re: [PATCH 4/7] FS-Cache: Export find_get_pages()
• Next by thread: Re: [PATCH 4/7] FS-Cache: Export find_get_pages()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]