Re: [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range()

Andrew Morton <[email protected]> writes:

>>  +		/*
>>  +		 * wbc->start == 0 && wbc->end == 0 is a special range,
>>  +		 * so this avoids using it.
>>  +		 */
>>  +		if (endbyte > 1)
>>  +			endbyte--;		/* inclusive */
>>  +	}
>
> Yes, the problem is that the interface is busted - start=0,end=0 is
> ambiguous and ->writepages() will get it wrong.
>
> So I think it's better to fix the interface...

I agree. And I think WB_SYNC_NONE with rage would be useful.
-- 
OGAWA Hirofumi <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range()
    • From: OGAWA Hirofumi <[email protected]>
  • Re: [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range()
• Next by Date: Re: [RFC][PATCH 1/2] Create initial kernel ABI header infrastructure
• Previous by thread: Re: [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range()
• Next by thread: how to use v4l / em2820 | em2840
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]