Re: [patch] avoid unaligned access when accessing poll stack

Jes Sorensen <[email protected]> writes:

>   	struct poll_list *walk;
>  	struct fdtable *fdt;
>  	int max_fdset;
> -	/* Allocate small arguments on the stack to save memory and be faster */
> -	char stack_pps[POLL_STACK_ALLOC];
> +	/* Allocate small arguments on the stack to save memory and be 
> +	   faster - use long to make sure the buffer is aligned properly
> +	   on 64 bit archs to avoid unaligned access */
> +	long stack_pps[POLL_STACK_ALLOC/sizeof(long)];
>  	struct poll_list *stack_pp = NULL;

struct poll_list stack_pps[POLL_STACK_ALLOC / sizeof(struct poll_list)];

is more readable, and probably gcc align it rightly?
-- 
OGAWA Hirofumi <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] avoid unaligned access when accessing poll stack
    • From: Andi Kleen <[email protected]>

• References:
  • [patch] avoid unaligned access when accessing poll stack
    • From: Jes Sorensen <[email protected]>

• Prev by Date: Re: [openib-general] updated InfiniBand 2.6.17 merge plans
• Next by Date: Re: Synchronizing Bit operations V2
• Previous by thread: Re: [patch] avoid unaligned access when accessing poll stack
• Next by thread: Re: [patch] avoid unaligned access when accessing poll stack
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]