Re: [-mm patch] arch/i386/kernel/apic.c: make modern_apic() static

On Fri, Mar 31, 2006 at 05:02:19PM +0200, Andi Kleen wrote:
> On Friday 31 March 2006 16:56, Adrian Bunk wrote:
> > This patch makes a nnedlessly global function static.
> 
> Disagree. It will be likely used in more code in the future.

If this "likely" case becomes reality at any time in the future, 
reverting my patch will be trivial.

OTOH, I have seen too many cases where people have said "I will need 
this soon", and one year later it was still unused.

> -Andi

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.16-mm2
    • From: Andrew Morton <[email protected]>
  • [-mm patch] arch/i386/kernel/apic.c: make modern_apic() static
    • From: Adrian Bunk <[email protected]>
  • Re: [-mm patch] arch/i386/kernel/apic.c: make modern_apic() static
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: NFS client (10x) performance regression 2.6.14.7 -> 2.6.15
• Next by Date: Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver
• Previous by thread: Re: [-mm patch] arch/i386/kernel/apic.c: make modern_apic() static
• Next by thread: [Patch:000/004]Unify pxm_to_node id ver.3.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]