On Thu, Mar 30 2006, Jens Axboe wrote:
> On Thu, Mar 30 2006, Andrew Morton wrote:
> > Jens Axboe <[email protected]> wrote:
> > >
> > > > > +static void *page_cache_pipe_buf_map(struct file *file,
> > > > > + struct pipe_inode_info *info,
> > > > > + struct pipe_buffer *buf)
> > > > > +{
> > > > > + struct page *page = buf->page;
> > > > > +
> > > > > + lock_page(page);
> > > > > +
> > > > > + if (!PageUptodate(page)) {
> > > >
> > > > || page->mapping == NULL
> > >
> > > Fixed
> >
> > Actually that wasn't right. If the page was truncated then we shouldn't
> > return -EIO to userspace. We should return zero, as this is the first
> > page.
>
> _if_ this is the first page, then agree.
>
> > Which means either returning an ERR_PTR here for -EIO or re-checking i_size
> > in the caller. Maybe the latter?
>
> The latter sounds better, I'll add that.
Actually that's a little hard, since you don't know what state buf->page
is in - it might be page cache, it might not be. So I opted for the
ERR_PTR approach, just returning -ENODATA on !page->mapping.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
