Jens Axboe <[email protected]> wrote:
>
> > The one-at-a-time logic looks OK from a quick scan. Do we have logic in
> > there to check that we're not overrunning i_size? (See the pain
> > do_generic_mapping_read() goes through).
>
> do_splice_to() checks that, should I move that checking further down in
> case the file is truncated?
Again, see do_generic_mapping_read()'s ghastly tricks - it checks i_size
after each readpage().
i_size can increase or decrease under our feet if we're not holding i_mutex
(and we don't want to). So userspace is being silly and the main things we
need to care about here are to not leak uninitialised data and to not oops.
A readpage() outside i_size will return either all-zeroes or some valid
data which isn't actually within i_size any more, so I guess we're OK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
