Hi!
> > So if you have a single core x86, you want X86_PC, and if you have HT or SMP,
> > you want GENERICARCH? If so, could this be done via selects or depends or at
> > least defaults in Kconfig?
>
> Yes, i think only SUSPEND_SMP is affect by this. I thought Rafael cced Pavel during
> that exchange, maybe i missed.
>
> >
> > Regards,
> >
> > Nigel
>
> How about this patch.
>
> Make SUSPEND_SMP depend on X86_GENERICARCH, since hotplug cpu requires !X86_PC
> due to some race in IPI handling. See more discussion here
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114303306032338&w=2
I can't see useful discussion there.
> Index: linux-2.6.16-git16/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.16-git16.orig/kernel/power/Kconfig
> +++ linux-2.6.16-git16/kernel/power/Kconfig
> @@ -96,5 +96,5 @@ config SWSUSP_ENCRYPT
>
> config SUSPEND_SMP
> bool
> - depends on HOTPLUG_CPU && X86 && PM
> + depends on HOTPLUG_CPU && X86 && PM && X86_GENERICARCH
> default y
Heh, great, so one more magic option that is required.
Plus GENERICARCH does not sound like something normal users would
enable:
config X86_GENERICARCH
bool "Generic architecture (Summit, bigsmp, ES7000, default)"
depends on SMP
help
This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
It is intended for a generic binary kernel.
(What does "default" mean there, anyway? X86_PC?)
Pavel
--
Picture of sleeping (Linux) penguin wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
