Re: [PATCH] PCI Error Recovery: e1000 network device driver

On Fri, Mar 24, 2006 at 04:00:02PM -0600, Linas Vepstas wrote:
> +	/* Perform card reset only on one instance of the card */
> +	if(0 != PCI_FUNC (pdev->devfn))
> +		return PCI_ERS_RESULT_RECOVERED;

You seem to have forgotton to put a ' ' after the 'if' in a number of
different places in this patch.  Also the (0 != foo) form is a bit
different from the traditional kernel coding style.

> +	switch(adapter->hw.mac_type) {

And here too.

Remember, "if" and "switch" are not functions...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] PCI Error Recovery: e1000 network device driver
    • From: [email protected] (Linas Vepstas)

• References:
  • [PATCH] PCI Error Recovery: e1000 network device driver
    • From: [email protected] (Linas Vepstas)

• Prev by Date: Re: -mm merge plans
• Next by Date: Re: [Patch 0/9] Performance
• Previous by thread: [PATCH] PCI Error Recovery: e1000 network device driver
• Next by thread: Re: [PATCH] PCI Error Recovery: e1000 network device driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]