[PATCH 03/14] NTFS: Fix a buggette in an "should be impossible" case handling

NTFS: Fix a buggette in an "should be impossible" case handling where we
      continued the attribute lookup loop instead of aborting it.

Signed-off-by: Anton Altaparmakov <[email protected]>

---

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

 fs/ntfs/ChangeLog |    2 ++
 fs/ntfs/attrib.c  |    4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

3ccc7384db3d762e834dfdae13c1d6434b2fdeab
diff --git a/fs/ntfs/ChangeLog b/fs/ntfs/ChangeLog
index 3d8d60b..d35a5c8 100644
--- a/fs/ntfs/ChangeLog
+++ b/fs/ntfs/ChangeLog
@@ -24,6 +24,8 @@ ToDo/Notes:
 	- Fix two compiler warnings on Alpha.  Thanks to Andrew Morton for
 	  reporting them.
 	- Fix an (innocent) off-by-one error in the runlist code.
+	- Fix a buggette in an "should be impossible" case handling where we
+	  continued the attribute lookup loop instead of aborting it.
 
 2.1.26 - Minor bug fixes and updates.
 
diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
index 9480a05..a92b9e9 100644
--- a/fs/ntfs/attrib.c
+++ b/fs/ntfs/attrib.c
@@ -1,7 +1,7 @@
 /**
  * attrib.c - NTFS attribute operations.  Part of the Linux-NTFS project.
  *
- * Copyright (c) 2001-2005 Anton Altaparmakov
+ * Copyright (c) 2001-2006 Anton Altaparmakov
  * Copyright (c) 2002 Richard Russon
  *
  * This program/include file is free software; you can redistribute it and/or
@@ -1048,7 +1048,7 @@ do_next_attr_loop:
 				le32_to_cpu(ctx->mrec->bytes_allocated))
 			break;
 		if (a->type == AT_END)
-			continue;
+			break;
 		if (!a->length)
 			break;
 		if (al_entry->instance != a->instance)
-- 
1.2.3.g9821

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 04/14] NTFS: Use buffer_migrate_page() for the ->migratepage function
    • From: Anton Altaparmakov <[email protected]>

• References:
  • [2.6-git] NTFS: Release 2.1.27
    • From: Anton Altaparmakov <[email protected]>
  • [PATCH 01/14] NTFS: Fix two compiler warnings on Alpha.
    • From: Anton Altaparmakov <[email protected]>
  • [PATCH 02/14] NTFS: Fix an (innocent) off-by-one error in the runlist code.
    • From: Anton Altaparmakov <[email protected]>

• Prev by Date: [PATCH 02/14] NTFS: Fix an (innocent) off-by-one error in the runlist code.
• Next by Date: [PATCH 04/14] NTFS: Use buffer_migrate_page() for the ->migratepage function
• Previous by thread: [PATCH 02/14] NTFS: Fix an (innocent) off-by-one error in the runlist code.
• Next by thread: [PATCH 04/14] NTFS: Use buffer_migrate_page() for the ->migratepage function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]