Re: [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up()

On Sun, 19 Mar 2006, Jesper Juhl wrote:

> Small cleanup patch for net/tipc/name_distr.c::tipc_named_node_up()

Not sure if you followed the discussion on the tipc mailinglist, so here's 
a short summary.

> Patch does the following:
> 
>  - Change a few pointer assignments from 0 to NULL (makes sparse happy).

Ok.

>  - Move a few variable assignment outside the tipc_nametbl_lock lock.

Ok.

>  - Make sure to free the allocated buffer before returning so we don't leak.

The additional kfree_skb() looks incorrect. If a buffer if allocated it 
will later be released by tipc_link_send().

/Per
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up()
    • From: "Jesper Juhl" <[email protected]>

• References:
  • [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up()
    • From: Jesper Juhl <[email protected]>

• Prev by Date: [patch 2/4 MKII] cpufreq_conservative: alter default responsiveness
• Next by Date: [patch 3/4 MKII] cpufreq_conservative: make for_each_cpu() safe
• Previous by thread: [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up()
• Next by thread: Re: [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]