[2.6 patch] ieee80211_wx.c: remove dead code

Since sec->key_sizes[] is an u8, len can't be < 0.

Spotted by the Coverity checker.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.16-rc6-mm1-full/net/ieee80211/ieee80211_wx.c.old	2006-03-14 03:01:43.000000000 +0100
+++ linux-2.6.16-rc6-mm1-full/net/ieee80211/ieee80211_wx.c	2006-03-14 03:02:02.000000000 +0100
@@ -505,7 +505,7 @@ int ieee80211_wx_get_encode(struct ieee8
 	len = sec->key_sizes[key];
 	memcpy(keybuf, sec->keys[key], len);
 
-	erq->length = (len >= 0 ? len : 0);
+	erq->length = len;
 	erq->flags |= IW_ENCODE_ENABLED;
 
 	if (ieee->open_wep)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] ieee80211_wx.c: remove dead code
    • From: "John W. Linville" <[email protected]>

• Prev by Date: fs/namespace.c:dup_namespace(): fix a use after free
• Next by Date: PATCH m68knommu clear frame-pointer in start_thread
• Previous by thread: fs/namespace.c:dup_namespace(): fix a use after free
• Next by thread: Re: [2.6 patch] ieee80211_wx.c: remove dead code
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]