Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)

Andrew,

Fixed both comments from Al Viro (thanks, Al):
- should have a separate helper
- should pass 0 instead of GFP_KERNEL in page_symlink()

+	page = find_or_create_page(mapping, 0,
+			mapping_gfp_mask(mapping) | gfp_mask);

this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit
more. As such a | operation isn't going to be useful....

(So I think that while Al's intention was good, the implication of it
isn't ;)

Oh no... Had to sleep well today... :/
Al, are you agree with the original patch then?
I don't think it is a good idea to introduce AND mask instead :)

Thanks,
Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [PATCH] Documentation: Make fujitsu/frv/kernel-ABI.txt 80 columns wide
• Next by Date: Re: [RFC PATCH] ext3 writepage() journal avoidance
• Previous by thread: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)
• Next by thread: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]