Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside

+	page = find_or_create_page(mapping, 0,
+			mapping_gfp_mask(mapping) | gfp_mask);

+int page_symlink(struct inode *inode, const char *symname, int len)
+{
+	return __page_symlink(inode, symname, len, GFP_KERNEL);

s/GFP_KERNEL/0/; if somebody has e.g. GFP_NOFS in their mapping flags,
you end up breaking their code.  We really pass extra flags to be added
to default ones; page_symlink() should pass 0.

thanks for noticing this.
fixed and resend.

Thanks,
Kirill


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
    • From: Al Viro <[email protected]>

• Prev by Date: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)
• Next by Date: Re: [RFC PATCH] ext3 writepage() journal avoidance
• Previous by thread: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
• Next by thread: Re: [PATCH 1 of 20] ipath - core driver header files
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]