Re: [Patch 4/7] Add sysctl for delay accounting

Arjan van de Ven wrote:

+/* Allocate task_delay_info for all tasks without one */
+static int alloc_delays(void)

I'm sorry but this function seems to be highly horrible

Could you be more specific ? Is it the way its coded or the design (preallocate, then assign)

itself ?

The function needs to allocate task_delay_info structs for all tasks that might

have been forked since the last time delay accounting was turned off.
Either we have to count how many such tasks there are, or preallocate
nr_tasks (as an upper bound) and then use as many as needed.

Thanks for reviewing so quickly.
-- Shailabh


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Patch 4/7] Add sysctl for delay accounting
    • From: Arjan van de Ven <[email protected]>

• References:
  • [Patch 0/7] Per-task delay accounting
    • From: Shailabh Nagar <[email protected]>
  • [Patch 4/7] Add sysctl for delay accounting
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch 4/7] Add sysctl for delay accounting
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [Patch 1/7] timespec diff utility
• Next by Date: Re: GFS2 Filesystem [13/16]
• Previous by thread: Re: [Patch 4/7] Add sysctl for delay accounting
• Next by thread: Re: [Patch 4/7] Add sysctl for delay accounting
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]