Re: [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module

On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote:
> +#define IFNULL(a) \
> +       if (unlikely(!(a)))

please please get rid of this!

first of all, gcc ALREADY treats null pointer checks as unlikely,
second of all this makes code entirely unreadable, so please just
use "if (!a)" where you would want to use IFNULL

(same goes for the variants of this just below this)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX
    • From: Hansjoerg Lipp <[email protected]>
  • [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module
    • From: Hansjoerg Lipp <[email protected]>

• Prev by Date: page cache question
• Next by Date: [Patch 0/7] Per-task delay accounting
• Previous by thread: Re: [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer
• Next by thread: Re: [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]