Re: [PATCH] Avoid calling down_read and down_write during startup

On Thu, Feb 23, 2006 at 04:16:31PM -0800, Andrew Morton wrote:
> down_write() unconditionally (and reasonably) does local_irq_enable() in
> the uncontended case.  And enabling local interrupts early in boot can
> cause crashes.

Why not do a down_write_trylock() instead first?  Then the code doesn't 
have the dependancy on system_state, which seems horribly fragile.

		-ben
-- 
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here 
and they've asked us to stop the party."  Don't Email: <[email protected]>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Avoid calling down_read and down_write during startup
    • From: Alan Stern <[email protected]>

• References:
  • Re: [PATCH] Register atomic_notifiers in atomic context
    • From: Andrew Morton <[email protected]>
  • [PATCH] Avoid calling down_read and down_write during startup
    • From: Alan Stern <[email protected]>
  • Re: [PATCH] Avoid calling down_read and down_write during startup
    • From: Benjamin LaHaise <[email protected]>
  • Re: [PATCH] Avoid calling down_read and down_write during startup
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Patch to reorder functions in the vmlinux to a defined order
• Next by Date: GFS2 Filesystem [0/16]
• Previous by thread: Re: [PATCH] Avoid calling down_read and down_write during startup
• Next by thread: Re: [PATCH] Avoid calling down_read and down_write during startup
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]