[PATCH] Move pci_dev_put outside a spinlock

Greg:

This patch (as659) fixes a might_sleep problem in the PCI core, by moving 
a call to pci_dev_put() outside the scope of a spinlock.

Alan Stern



Signed-off-by: Alan Stern <[email protected]>

---

Maybe this has already been fixed; if so the fix isn't in your 
development tree for 2.6.16-rc4.

Index: usb-2.6/drivers/pci/search.c
===================================================================
--- usb-2.6.orig/drivers/pci/search.c
+++ usb-2.6/drivers/pci/search.c
@@ -246,9 +246,9 @@ pci_get_subsys(unsigned int vendor, unsi
 	}
 	dev = NULL;
 exit:
-	pci_dev_put(from);
 	dev = pci_dev_get(dev);
 	spin_unlock(&pci_bus_lock);
+	pci_dev_put(from);
 	return dev;
 }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: time_interpolator: Use readq_relaxed() instead of readq().
• Next by Date: Re: Kernel panic when compiling with SMP support
• Previous by thread: time_interpolator: Use readq_relaxed() instead of readq().
• Next by thread: [PATCH] reduce syslog clutter
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]