Re: [PATCH v2] Provide an interface for getting the current tick length

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, 16 Feb 2006, john stultz wrote:

> > +u64 current_tick_length(void)
> > +{
> > +	long delta_nsec;
> > +
> > +	delta_nsec = tick_nsec + adjtime_adjustment() * 1000;
> > +	return ((u64) delta_nsec << (SHIFT_SCALE - 10)) + time_adj;
> > +}
> You've got time_adj here, but you're not using what's been accumulated
> in time_phase, is that really ok?
> Other then that it looks ok to me. I know Roman is working on related
> code, so I CC'ed him on this.

I was only thinking about the possibility of increasing the precision 
already, but that can still be done later.
Otherwise this function will only become simpler, so there's no real 
problem. Actually it should even make NTP4 conversion easier, if ppc uses 
this value instead of duplicating the calculation.

bye, Roman
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at
Please read the FAQ at

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux