Sergey Vlasov wrote:
> On Sat, 11 Feb 2006 01:15:23 +0100 Pierre Ossman wrote:
>
>> diff --git a/include/linux/pci_regs.h b/include/linux/pci_regs.h
>> index d27a78b..e6deda5 100644
>> --- a/include/linux/pci_regs.h
>> +++ b/include/linux/pci_regs.h
>> @@ -108,6 +108,9 @@
>> #define PCI_INTERRUPT_PIN 0x3d /* 8 bits */
>> #define PCI_MIN_GNT 0x3e /* 8 bits */
>> #define PCI_MAX_LAT 0x3f /* 8 bits */
>> +#define PCI_SLOT_INFO 0x40 /* 8 bits */
>> +#define PCI_SLOT_INFO_SLOTS(x) ((x >> 4) & 7)
>> +#define PCI_SLOT_INFO_FIRST_BAR_MASK 0x07
>
> Does this really belong here? This register is specific to the SDHCI
> class, while all other definitions in pci_regs.h apply to all PCI
> devices.
>
> drivers/mmc/sdhci.h seems to be a more logical place for SLOT_INFO
> definitions.
>
Possibly. I wasn't sure of the appropriate header for PCI information.
Although specific for the SDHCI hosts, it's still a PCI register and not
a device register.
If the consensus is that this should be in the driver header then I'll
gladly move it.
Rgds
Pierre
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
