Re: [RFT/PATCH] slab: consolidate allocation paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This consolidation patch looks ok to me on first read, though others
are certainly more expert in this code than I am.  Certainly cleanup,
ifdef reduction and consolidation of mm/slab.c is a worthwhile goal.
That code is rough for folks like me to follow.

Two issues I can see:

  1) This patch increased the text size of mm/slab.o by 776
     bytes (ia64 sn2_defconfig gcc 3.3.3), which should be
     justified.  My naive expectation would have been that
     such a source code consolidation patch would be text
     size neutral, or close to it.

  2) You might want to hold off this patch for a few days,
     until the dust settles from my memory spread patch.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <[email protected]> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux